fix(KFLUXBUGS-1117): use FindAllStringSubmatch() to get ALL matches #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psturc
reviewed
Feb 20, 2024
* Currently, the `FindStringSubmatch()` returns the first Match and its Groups, ignoring the other matches. * This works fine, if the first match is what we're interested in (the e2e test job's url), but it won't return anything if it's the second match. * This commit instead uses `FindAllStringSubmatch()` to return ALL matches and their groups, and goes through them one by one to ignore the ones with string "images" or ")" in them. Signed-off-by: Dheeraj<[email protected]>
dheerajodha
force-pushed
the
KFLUXBUGS-1117
branch
from
7fe8082 to
2f3eaf8
Compare
psturc
approved these changes
Mar 15, 2024
psturc
pushed a commit
that referenced
this pull request
Apr 17, 2024
) * Currently, the `FindStringSubmatch()` returns the first Match and its Groups, ignoring the other matches. * This works fine, if the first match is what we're interested in (the e2e test job's url), but it won't return anything if it's the second match. * This commit instead uses `FindAllStringSubmatch()` to return ALL matches and their groups, and goes through them one by one to ignore the ones with string "images" or ")" in them. Signed-off-by: Dheeraj<[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindStringSubmatch()returns the first Match and its Groups, ignoring the other matches.FindAllStringSubmatch()to return ALL matches and their groups, and goes through them one by one to ignore the ones with string "images" or ")" in them.