Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt konflux-demo for konflux-ci #1267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

psturc
Copy link
Member

@psturc psturc commented Jul 18, 2024

Description

  • update konflux-demo test to be compatible with both downstream (infra-deployments) and upstream (konflux-ci/konflux-ci) versions of konflux

Issue ticket number and link

KONFLUX-3683

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

TBD

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Jul 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@psturc psturc changed the title fix: adapt rhtap-demo for konflux-ci fix: adapt konflux-demo for konflux-ci Nov 1, 2024
@github-actions github-actions bot added 1-5 min and removed 5-10 min labels Nov 1, 2024
Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from psturc. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc psturc force-pushed the KONFLUX-3683 branch 2 times, most recently from 6405e74 to fd3ca67 Compare December 12, 2024 11:14
@psturc
Copy link
Member Author

psturc commented Jan 20, 2025

/retest

@psturc psturc marked this pull request as ready for review January 20, 2025 21:46
@openshift-ci openshift-ci bot requested review from jinqi7 and pmacik January 20, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants