Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXDP-108): Allow to pass via COMPONENT_IMAGE env images with tag and sha #1492

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

flacatus
Copy link
Collaborator

Description

Extend functinality to add via COMPONENT_IMAGE images like: quay.io/redhat-user-workloads/rhtap-build-tenant/build-service/build-service@sha256:20ca83111840a28c870750d576a4e2bdf0c8452f2ed3e1a21a64b9f2cbba580d

This images contain the tag name and the sha

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from kasemAlem and psturc January 26, 2025 17:57
magefiles/rulesengine/repos/common.go Dismissed Show dismissed Hide dismissed
magefiles/rulesengine/repos/common.go Dismissed Show dismissed Hide dismissed
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 10acfc5 into konflux-ci:main Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants