feat(KFLUXUI-125): allow sorting pipeline runs by status and type #68
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 80.15% 80.23% +0.07%
==========================================
Files 569 569
Lines 21391 21447 +56
Branches 5299 5318 +19
==========================================
+ Hits 17146 17207 +61
+ Misses 4220 4215 -5
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marcin-michal
force-pushed
the
KFLUXUI-125
branch
from
31eb20c to
25e824c
Compare
|
/retest |
|
Overall LGTM. I still need to take a closer look and test the functionality live before final review. |
|
LGTM |
| @@ -145,6 +184,41 @@ const SnapshotPipelineRunsList: React.FC<React.PropsWithChildren<SnapshotPipelin | |||
| value={nameFilter} | |||
| /> | |||
| </ToolbarItem> | |||
| <ToolbarItem> | |||
| <Select | |||
There was a problem hiding this comment.
See if you can create a Reusable component for status filter that can be used in all of the pipeline run list pages
| const setTypeFilters = (filters: string[]) => setTypeFiltersParam(filters.join(',')); | ||
|
|
||
| const typeFilterObj = React.useMemo(() => { | ||
| return pipelineRuns.reduce((acc, plr) => { | ||
| if (customFilter && !customFilter(plr)) { | ||
| return acc; | ||
| } |
There was a problem hiding this comment.
This same code is being used in Other component, Create reusable utilities or component for the toolbar
@sahil143 Thanks, did not notice pipeline runs were in the Commit details page as well. By Component Details page, do you mean the |
Fixes
https://issues.redhat.com/browse/KFLUXUI-125
Description
Before, in the application's activity tab, it was only possible to sort pipeline runs by status, and in the snapshot's pipeline runs by type. Now, it's possible to sort by both of these attributes in either of the page, making it more consistent.
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Go to the activity tab for any application and view the pipeline runs. To view the snapshots pipeline runs, click on any pipeline run from the previous page, click on the snapshot and select the pipeline runs tab.
Browser conformance: