fix: ErrorBoundary to capture unknown errors #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 80.01% 80.13% +0.12%
==========================================
Files 569 570 +1
Lines 21379 21530 +151
Branches 5037 5342 +305
==========================================
+ Hits 17107 17254 +147
- Misses 4248 4250 +2
- Partials 24 26 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sahil143
commented
Jan 27, 2025
src/routes/RouteErrorBoundary.tsx
Outdated
| const httpError = error as HttpError; | ||
| <ErrorEmptyState | ||
| httpError={httpError} | ||
| title="Unable to load pipeline runs" |
There was a problem hiding this comment.
Reminder: Fix the text.
There was a problem hiding this comment.
Will the text be fixed in this PR?
|
LGTM |
StanislavJochman
previously approved these changes
Jan 27, 2025
|
LGTM |
abhinandan13jan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.