Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): add source secrets #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented Jan 15, 2025

Fixes

https://issues.redhat.com/browse/HAC-5834

Description

PR ready for review

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Screenshot 2025-01-20 at 6 12 15 PM Screenshot 2025-01-20 at 6 10 38 PM Screenshot 2025-01-20 at 6 09 51 PM Screenshot 2025-01-20 at 6 09 42 PM

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@abhinandan13jan abhinandan13jan changed the title [WIP] feat(secret): add source secrets feat(secret): add source secrets Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 70.47619% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (2c479bd) to head (85f9b23).

Files with missing lines Patch % Lines
src/utils/validation-utils.ts 34.48% 19 Missing ⚠️
src/components/Secrets/SecretForm.tsx 10.00% 9 Missing ⚠️
src/utils/create-utils.ts 81.81% 2 Missing ⚠️
src/components/Secrets/SecretModal.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   80.13%   80.18%   +0.04%     
==========================================
  Files         570      571       +1     
  Lines       21529    21599      +70     
  Branches     5076     5343     +267     
==========================================
+ Hits        17253    17319      +66     
- Misses       4251     4254       +3     
- Partials       25       26       +1     
Flag Coverage Δ
unittests 80.18% <70.47%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahil143 sahil143 requested a review from JoaoPedroPP January 23, 2025 10:03
@JoaoPedroPP
Copy link
Contributor

JoaoPedroPP commented Jan 23, 2025

LGTM

All the modifications are working properly.
The conflicts are related to #61. Please rebase the branch and this will be following issues

  • src/components/Secrets/SecretForm.tsx
    1. I believe it's a mix of both. From my side it's important to keep options = []
    2. Also a mix of both. This time is important to keep ...getSupportedPartnerTaskKeyValuePairs(value, optionsValues)
  • src/components/Secrets/SecretModal.tsx
    1. Keep yours modification, just add the BuildTimeSecret in the import from types
  • src/components/Secrets/tests_/SecretModal.spec.tsx
    1. Keep your modification, just add SecretType in the import from types
    2. Keep both and remove the additional describe ('SecretForm', () => {

Probably there are other things to fix since there were changes on how the build time secret was model

Is it possible to cover the missing lines in Codecov/patch?

@abhinandan13jan
Copy link
Contributor Author

LGTM

All the modifications are working properly. The conflicts are related to #61. Please rebase the branch and this will be following issues

  • src/components/Secrets/SecretForm.tsx

    1. I believe it's a mix of both. From my side it's important to keep options = []
    2. Also a mix of both. This time is important to keep ...getSupportedPartnerTaskKeyValuePairs(value, optionsValues)
  • src/components/Secrets/SecretModal.tsx

    1. Keep yours modification, just add the BuildTimeSecret in the import from types
  • src/components/Secrets/tests_/SecretModal.spec.tsx

    1. Keep your modification, just add SecretType in the import from types
    2. Keep both and remove the additional describe ('SecretForm', () => {

Probably there are other things to fix since there were changes on how the build time secret was model

Is it possible to cover the missing lines in Codecov/patch?

@JoaoPedroPP thanks for the references JP, I'll look into these

@abhinandan13jan abhinandan13jan force-pushed the add-source-secret branch 2 times, most recently from eb945c7 to 3ebbc28 Compare January 28, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants