-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secret): add source secrets #82
base: main
Are you sure you want to change the base?
feat(secret): add source secrets #82
Conversation
fdf1db5
to
6d49c91
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 80.13% 80.18% +0.04%
==========================================
Files 570 571 +1
Lines 21529 21599 +70
Branches 5076 5343 +267
==========================================
+ Hits 17253 17319 +66
- Misses 4251 4254 +3
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM All the modifications are working properly.
Probably there are other things to fix since there were changes on how the build time secret was model Is it possible to cover the missing lines in Codecov/patch? |
@JoaoPedroPP thanks for the references JP, I'll look into these |
eb945c7
to
3ebbc28
Compare
1602728
to
8a9c729
Compare
8a9c729
to
85f9b23
Compare
Fixes
https://issues.redhat.com/browse/HAC-5834
Description
PR ready for review
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: