fix: ec regex to extract voilation reports from tkn logs #84
+110
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
========================================
Coverage 80.11% 80.11%
========================================
Files 570 570
Lines 21444 21447 +3
Branches 5308 5050 -258
========================================
+ Hits 17179 17182 +3
- Misses 4240 4241 +1
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CryptoRodeo
approved these changes
Jan 24, 2025
|
/test |
| try { | ||
| return JSON.parse(extractedLogs[0]); | ||
| } catch { | ||
| return null; |
There was a problem hiding this comment.
Would not make sense to propagate this higher? And ignore it where it is used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.redhat.com/browse/KONFLUX-5697
Description
with tekton results upgrade tkn logs format changed due to which logs parsing is failing on UI.
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: