Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-223): shorten the prefix of ImageRepository names #85

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

janaki29
Copy link
Contributor

Feature

https://issues.redhat.com/browse/KFLUXUI-223

Description

UI: shortened the prefix of ImageRepository names

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@JoaoPedroPP
Copy link
Contributor

/ok-to-test

@JoaoPedroPP
Copy link
Contributor

/retest

Copy link
Contributor

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JoaoPedroPP
JoaoPedroPP previously approved these changes Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (2c479bd) to head (53d1422).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files         570      570           
  Lines       21529    21529           
  Branches     5076     5076           
=======================================
  Hits        17253    17253           
  Misses       4251     4251           
  Partials       25       25           
Flag Coverage Δ
unittests 80.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CryptoRodeo
CryptoRodeo previously approved these changes Jan 17, 2025
@StanislavJochman
Copy link
Contributor

LGTM, but can not find where in the listed doc is listed how it should be shortened.

@janaki29
Copy link
Contributor Author

LGTM, but can not find where in the listed doc is listed how it should be shortened.

You can check it here:
https://github.com/konflux-ci/docs/pull/182/files

@testcara
Copy link
Contributor

LGTM

@sahil143
Copy link
Collaborator

LGTM, but can not find where in the listed doc is listed how it should be shortened.

You can check it here: https://github.com/konflux-ci/docs/pull/182/files

Linked PR suggests only using the component name for the image repository CR. I think we can safely remove the application name because component names are unique per namespace.

@janaki29
Copy link
Contributor Author

LGTM, but can not find where in the listed doc is listed how it should be shortened.

You can check it here: https://github.com/konflux-ci/docs/pull/182/files

Linked PR suggests only using the component name for the image repository CR. I think we can safely remove the application name because component names are unique per namespace.

Updated.

src/utils/create-utils.ts Outdated Show resolved Hide resolved
@sahil143
Copy link
Collaborator

/test

@sahil143 sahil143 merged commit 438fbb0 into konflux-ci:main Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants