-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KFLUXUI-223): shorten the prefix of ImageRepository names #85
Conversation
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 80.13% 80.13%
=======================================
Files 570 570
Lines 21529 21529
Branches 5076 5076
=======================================
Hits 17253 17253
Misses 4251 4251
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM, but can not find where in the listed doc is listed how it should be shortened. |
You can check it here: |
LGTM |
Linked PR suggests only using the component name for the image repository CR. I think we can safely remove the application name because component names are unique per namespace. |
…s, removed application name
765aa9a
Updated. |
Co-authored-by: Sahil Budhwar <[email protected]>
/test |
Feature
https://issues.redhat.com/browse/KFLUXUI-223
Description
UI: shortened the prefix of ImageRepository names
Type of change