-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-6512): restore allow input CVE for release #97
base: main
Are you sure you want to change the base?
Conversation
4b34b89
to
f67cce3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
========================================
Coverage 80.14% 80.14%
========================================
Files 570 570
Lines 21536 21536
Branches 5076 5332 +256
========================================
Hits 17260 17260
+ Misses 4251 4250 -1
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f67cce3
to
07935dc
Compare
I was looking at the history of this file here and in the HAC. I found out that the change from The CVEFormContent has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the reference of the schema.
07935dc
to
69348bd
Compare
@@ -40,7 +40,7 @@ const CVEFormContent: React.FC<CVEFormContentProps> = ({ modalToggle }) => { | |||
</TextContent> | |||
</StackItem> | |||
<StackItem> | |||
<InputField data-test="cve-issue-id" label="CVE ID" name="id" required /> | |||
<InputField data-test="cve-issue-id" label="CVE ID" name="key" required /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why label is ID and name is key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice question. Looking at the history of this file in the HAC repository I found this PR#944. There you can find the ticket KFLUXUI-120(KFLUXBUGS-1203) and I understood that is was a design change that replace key
for id
. However to record the CVE in konflux release the correct schema field name is key
. In this case I choose to preserve design and change only the field name to the correct name.
69348bd
to
cfedee1
Compare
LGTM |
Fixes
KONFLUX-6512
Description
Allow to add CVEs while releasing components
Type of change
Screen shots / Gifs for design review
Browser conformance: