A simpler fix to the event type environment variable faulty check #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on The SeaLights-MPC Saga:
SeaLights asked that we'll add a testing phase to the github workflow that runs a SeaLights code scan on the main branch after it's been merged with new code.
This basically made sealights-mpc-test-ci.yaml extremely similar to this workflow and so I added code that runs this scan-and-test procedure to on->push events. Steps that need to run differently on pull requests and on push are checked to see how to run them.
Thus the name change to sealights-mpc-test-ci.yaml, removing sealights-mpc-test-on-merged-main.yaml and trigger-sealights-mpc-test-on-merged-main.yaml. codecov-main.yaml is also removed because mpc-test-sealights.yaml is already running codecov action. This was done in #372
Today's episode:
The way the if checks on push/pull_request steps is not written correctly invalidate the workflow, causing it to fail no matter what runs. This is a fix I tested in a small test repo