add performance tests for namespace-lister #38
Merged
+333
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filariow
force-pushed
the
perf-test
branch
8 times, most recently
from
0e8d120 to
5e927b0
Compare
sadlerap
reviewed
Jan 27, 2025
| @@ -6,7 +6,7 @@ ARG TARGETARCH | |||
| WORKDIR /namespace-lister | |||
|
|
|||
| # Copy the Go Modules manifests | |||
| COPY go.mod go.sum . | |||
| COPY go.mod go.sum ./ | |||
There was a problem hiding this comment.
I don't see a difference in behavior - why is this needed?
There was a problem hiding this comment.
I applied a fix for a complaint from my linter. When multiple files are copied, it's best practice to explicitly declare a folder.
There was a problem hiding this comment.
Then maybe we should have something like this?
Suggested change
| COPY go.mod go.sum ./ | |
| COPY go.mod go.sum /namespace-lister/ |
There was a problem hiding this comment.
we are already setting the WORKDIR to /namespace-lister. I'd prefer this to remain relative to the WORKDIR
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
sadlerap
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Ilario [email protected]