Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose metrics on /metrics #39

Merged
merged 1 commit into from
Jan 27, 2025
Merged

expose metrics on /metrics #39

merged 1 commit into from
Jan 27, 2025

Conversation

sadlerap
Copy link
Collaborator

@sadlerap sadlerap commented Jan 24, 2025

expose metrics on /metrics

We expose four metrics:

  • namespace_lister_api_counter, which counts the number of requests we receive. It's broken down by the method and response code of each request we process.
  • namespace_lister_api_latency, which measures the latency of each request we process. This is reported as a histogram.
  • namespace_lister_api_response_size, which measures how large each response we send is. This is also reported as a histogram.
  • namespace_lister_api_requests_in_flight, which measures how many requests are currently processing.

filariow
filariow previously approved these changes Jan 24, 2025
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadlerap sadlerap marked this pull request as ready for review January 27, 2025 17:04
We expose four metrics:
- namespace_lister_api_counter, which counts the number of requests we receive.  It's
  broken down by the method and response code of each request we
  process.
- namespace_lister_api_latency, which measures the latency of each request we process.
  This is reported as a histogram.
- namespace_lister_api_response_size, which measures how large each response we send is.
  This is also reported as a histogram.
- namespace_lister_api_requests_in_flight, which measures how many
  requests are currently processing.

Signed-off-by: Andy Sadler <[email protected]>
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

well done! 🎉

@sadlerap sadlerap merged commit 1476179 into konflux-ci:main Jan 27, 2025
7 checks passed
@sadlerap sadlerap deleted the metrics branch January 27, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants