-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Union matches: select type by number of matching fields #264
base: master
Are you sure you want to change the base?
Conversation
…on_matches at the end as base for checking the matches when strict_unions_match is false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it safely solves the issue
the sort orders ascending
There was an unintended bug in my code. I fixed it with 39d01b7. Python default sorting is ascending and I wanted to get a quotient of sets. The test passed by accident.
|
covers regression I've introduced unintentionally
@m-aciek I'd say this is not a minor change, as it changes the internal behavior of the library: from "match first" to "match best"—which also might not be a trivial thing to say what it means that one structure matches best and not the other. I could envision this new behavior as an opt-in feature, i.e. So my proposed solution is:
I know it's quite a lot and would love to help, but struggle to find the time. Would you be willing to try to add/finish all of the pieces described above? |
Closes #263.