-
Notifications
You must be signed in to change notification settings - Fork 113
Bug fix and feature to prevent resuming with no filament #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the fix. will check it but who will create a new Version for the Octoprint Plugin Manager? I installed it only over Plugintool via Octoprint. The last version what i see over the octoprint tool is the old version Filament Sensor Reloaded: 1.1.0 (Bugfix). Who will do a new Version for Octoprint Pluginmanager? If it is ready i can test your fix. |
|
@raindancer2204 If you want to test the fix you can do so by cloning my fork and adding everything to a .zip file, and install it using the "from uploaded archive" option in OctoPrint plugin manager. |
|
@draagc should i remove the old filament sensor reloaded plugin and than install your zip file? Or install it over the existing version. On with Octoprint Version do you made your tests? |
|
@raindancer2204 The zip file should replace the already installed plug-in, so you can just install it over it. However, if you encounter issues you can always uninstall the plug-in an re-install it using the zip file. It has been tested on both 1.3.11 and 1.3.10. |
|
Hi draggc, Hello I checked your build and I noticed the following. Important the structure of the hardware and the wiring is the same for all 3 printers. Test with 2 i3 Mega with Octoprint Version 1.3.11 was successful. Test with the Anycubic Chiron here it comes to a strange mistake. The test GCODE I printed on the Chiron with the SD card here he ran through clean. The following error about Octoprint the pressure goes unexpectedly after about 1.5 hours in break. The filament is full and the gpio read did not say anything else. I can rule it out mechanically. Can it be that it is queried too often? Would not it last every second? I have more Retract here. Enclosed the octoprint.log: 2019-07-12 16:55:21,988 - octoprint.plugins.filamentreload - INFO - Filament detected! |
These modifications solve issue #46 and add the feature to prevent resuming the printer when no filament is present (#33). I have also added an option in settings to enable/disable this functionality.