feat(kontext): support user-token runtime connect type (sdk 0.2.0)#29
Merged
Conversation
There was a problem hiding this comment.
Inline findings posted:
- [LOW][testing] Architectural finding (
codex-rs/core/src/kontext_dev.rs:794)
Reviewer summary:
- Bumped
kontext-dev-sdkto0.2.0and updated lockfiles. - Added explicit handling for
RuntimeIntegrationConnectTypeto provide better user guidance for disconnected integrations. - Added tests to verify payload parsing for the new
user_tokenconnect type.
Scores and diagnostics
- Architecture: 7.0/10
- Organization: 7.0/10
- Cleanliness: 7.0/10
- Overall: 7.0/10
- Candidate findings: 1
- Published inline: 1
- Published summary-only: 0
- Suppressed findings: 0
Limitations
-
Cannot verify the exact structure of kontext_dev_sdk::mcp::RuntimeIntegrationRecord as it is in an external/workspace crate not included in the diff.
-
Model:
gemini-3.1-pro-preview -
Omitted files: 0
Generated at 2026-03-04T13:37:05.810Z.
There was a problem hiding this comment.
Inline findings posted:
- [LOW][maintainability] Architectural finding (
codex-rs/Cargo.toml:99)
Reviewer summary:
- Bumped
kontext-dev-sdkto0.2.0and updated lockfiles. - Added handling for
RuntimeIntegrationConnectTypeto provide more specific user guidance when integrations are disconnected. - Added tests to verify the parsing of the new
connectTypefield in runtime integration payloads. - Added a new
codexbinary alias incodex-rs/cli/Cargo.toml.
Scores and diagnostics
-
Architecture: 7.0/10
-
Organization: 7.0/10
-
Cleanliness: 7.0/10
-
Overall: 7.0/10
-
Candidate findings: 1
-
Published inline: 1
-
Published summary-only: 0
-
Suppressed findings: 0
-
Model:
gemini-3.1-pro-preview -
Omitted files: 0
Generated at 2026-03-04T14:05:05.568Z.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kontext-dev-sdkworkspace dependency to0.2.0Cargo.lock,MODULE.bazel.lock) for the SDK/core cutoverRuntimeIntegrationConnectTypehandling for disconnected integrations inkontext_devruntimeUserTokenas per-user token/API key requirement in user guidance logsconnectType: "user_token"acceptedconnectTyperejected as invalid payloadValidation
cargo test -p codex-core kontext_dev::testsjust bazel-lock-check