Skip to content

merge: hard-cutover sync main into kontext-dev #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michiosw merged 5 commits into from
Mar 4, 2026
Merged

merge: hard-cutover sync main into kontext-dev #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a59386
add new scopes to login (#12383)
adaley-openai Mar 4, 2026
67e70c3
merge: hard-cutover sync upstream/main into main
michiosw Mar 4, 2026
4c818d2
fix(ci): skip upstream npm staging on fork sync PRs
michiosw Mar 4, 2026
3f4e3cd
Merge pull request #30 from kontext-dev/sync/upstream-main-to-main
michiosw Mar 4, 2026
3a2416f
merge: hard-cutover sync main into kontext-dev
michiosw Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions codex-rs/core/src/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,6 @@ async fn request_chatgpt_token_refresh(
client_id: CLIENT_ID,
grant_type: "refresh_token",
refresh_token,
scope: "openid profile email",
};

let endpoint = refresh_token_endpoint();
Expand Down Expand Up @@ -722,7 +721,6 @@ struct RefreshRequest {
client_id: &'static str,
grant_type: &'static str,
refresh_token: String,
scope: &'static str,
}

#[derive(Deserialize, Clone)]
Expand Down
3 changes: 2 additions & 1 deletion codex-rs/login/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,8 @@ fn build_authorize_url(
("redirect_uri".to_string(), redirect_uri.to_string()),
(
"scope".to_string(),
"openid profile email offline_access".to_string(),
"openid profile email offline_access api.connectors.read api.connectors.invoke"
Copy link
Copy Markdown

@kontext-review kontext-review Bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW][maintainability] Architectural finding

Impact: Can reduce maintainability or correctness if left unresolved.
Suggested fix: Apply a targeted refactor and add/adjust tests where needed.
Evidence: The OAuth scopes are hardcoded as a single string literal. If these scopes are referenced in other parts of the application (e.g., token validation), extracting them to a shared constant would prevent drift.

.to_string(),
),
(
"code_challenge".to_string(),
Expand Down
Loading