Skip to content

fix(dashboard): contain command drawer text#157

Merged
hasandemirkiran merged 1 commit into
mainfrom
feat/eng-355-command-drawer-overflow
May 18, 2026
Merged

fix(dashboard): contain command drawer text#157
hasandemirkiran merged 1 commit into
mainfrom
feat/eng-355-command-drawer-overflow

Conversation

@hasandemirkiran
Copy link
Copy Markdown
Contributor

@hasandemirkiran hasandemirkiran commented May 18, 2026

Summary

  • Fixes command/details drawer horizontal overflow for ENG-355.
  • Adds drawer-level horizontal containment and min-w-0 constraints so the inspector grid cannot expand past the sheet.
  • Wraps long command, reason, analysis, and metadata values inside the drawer using overflow-wrap:anywhere instead of clipping outside the visible panel.

Verification

  • pnpm --dir web/guard-dashboard typecheck
  • scripts/build-guard-dashboard-assets.sh
  • go test ./...

Notes

  • Attempted a local automated browser check with the built dashboard bundle, but this workspace does not have Playwright/Puppeteer installed.

Copy link
Copy Markdown
Contributor Author

hasandemirkiran commented May 18, 2026

@hasandemirkiran hasandemirkiran force-pushed the feat/eng-328-dashboard-diagnostics branch from b574bcd to b899b30 Compare May 18, 2026 15:03
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-355-command-drawer-overflow branch from 3367e91 to 5311d80 Compare May 18, 2026 15:03
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-328-dashboard-diagnostics branch from b899b30 to f968a5f Compare May 18, 2026 15:10
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-355-command-drawer-overflow branch from 5311d80 to ca834de Compare May 18, 2026 15:10
@hasandemirkiran hasandemirkiran marked this pull request as ready for review May 18, 2026 15:11
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 18, 2026

Greptile Summary

This PR updates the Guard dashboard command/details drawer to better contain long text. It changes:

  • Adds horizontal overflow containment to the right-side sheet.
  • Applies min-w-0 and wrapping constraints inside the inspector layout.
  • Wraps long command, reason, analysis, metadata, and signal values.
  • Rebuilds the bundled dashboard assets referenced by index.html.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
web/guard-dashboard/src/App.tsx Adds drawer-level horizontal overflow containment to the sheet.
web/guard-dashboard/src/dashboard/Inspector.tsx Adds wrapping and width constraints across inspector content.
web/guard-dashboard/src/dashboard/shared.tsx Updates shared definition-list cells to wrap long labels and values.

Reviews (2): Last reviewed commit: "fix(dashboard): contain command drawer t..." | Re-trigger Greptile

Comment thread web/guard-dashboard/src/dashboard/Inspector.tsx Outdated
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-355-command-drawer-overflow branch from ca834de to f3c82e3 Compare May 18, 2026 15:19
@hasandemirkiran hasandemirkiran requested a review from michiosw May 18, 2026 15:23
michiosw
michiosw previously approved these changes May 18, 2026
Copy link
Copy Markdown
Contributor

michiosw commented May 18, 2026

Merge activity

@michiosw michiosw changed the base branch from feat/eng-328-dashboard-diagnostics to graphite-base/157 May 18, 2026 16:33
@michiosw michiosw force-pushed the graphite-base/157 branch from f968a5f to d850ae3 Compare May 18, 2026 19:37
@michiosw michiosw force-pushed the feat/eng-355-command-drawer-overflow branch from f3c82e3 to 2ed4159 Compare May 18, 2026 19:37
@michiosw michiosw changed the base branch from graphite-base/157 to feat/eng-328-dashboard-diagnostics May 18, 2026 19:37
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-328-dashboard-diagnostics branch from d850ae3 to 60aa70c Compare May 18, 2026 19:39
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-355-command-drawer-overflow branch from 2ed4159 to 8fbafca Compare May 18, 2026 19:39
@hasandemirkiran hasandemirkiran changed the base branch from feat/eng-328-dashboard-diagnostics to graphite-base/157 May 18, 2026 19:42
@hasandemirkiran hasandemirkiran changed the base branch from graphite-base/157 to main May 18, 2026 19:43
@hasandemirkiran hasandemirkiran dismissed michiosw’s stale review May 18, 2026 19:43

The base branch was changed.

@hasandemirkiran hasandemirkiran force-pushed the feat/eng-355-command-drawer-overflow branch from 8fbafca to 6b59fdb Compare May 18, 2026 19:43
@hasandemirkiran hasandemirkiran merged commit 4107e31 into main May 18, 2026
5 checks passed
@hasandemirkiran hasandemirkiran deleted the feat/eng-355-command-drawer-overflow branch May 18, 2026 19:46
michiosw pushed a commit that referenced this pull request May 18, 2026
🤖 I have created a release *beep* *boop*
---


## [0.7.0](v0.6.0...v0.7.0) (2026-05-18)


### Features

* add local guard judge contract ([#132](#132)) ([ef6a3cd](ef6a3cd))
* **cli:** make kontext start local-first ([#140](#140)) ([02a34bf](02a34bf))
* **dashboard:** show guard diagnostics ([#156](#156)) ([dcbdf4a](dcbdf4a))
* **guard:** add deterministic policy engine ([#131](#131)) ([3a0f16e](3a0f16e))
* **guard:** add policy config store ([#135](#135)) ([520c3b6](520c3b6))
* **guard:** add policy profile dashboard ([#137](#137)) ([0b0e856](0b0e856))
* **guard:** connect deterministic policy and judge ([#154](#154)) ([25f0d32](25f0d32))
* manage local judge runtime ([#136](#136)) ([09f4fc0](09f4fc0))
* **runtime service:** Guard now starts a Unix-socket localruntime.Service alongside the existing HTTP daemon ([#122](#122)) ([3e87e12](3e87e12))
* **runtime service:** Introduce runtime service and make existing Unix socket more generic ([#121](#121)) ([2bbaa93](2bbaa93))


### Bug Fixes

* **dashboard:** contain command drawer text ([#157](#157)) ([4107e31](4107e31))
* **dashboard:** polish activity summary and log groups ([#153](#153)) ([fc79101](fc79101))
* harden npm dependency resolution ([#114](#114)) ([86eadf5](86eadf5))
* optimize judge fixture category matching ([#146](#146)) ([0bad7ab](0bad7ab))
* **repo:** remove repo-wide codeowners ([#133](#133)) ([73557f0](73557f0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants