chore: updated dev ssr application based on official docs#1105
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SSR (Server-Side Rendering) configuration for the Angular development application by extracting shared configuration into separate files and updating the bootstrap code. The main goal is to improve code organization by centralizing application configuration.
- Extracted shared Angular providers into
config.tsandconfig.server.tsfiles - Refactored
main.tsandmain.server.tsto use the new configuration files - Added README documentation for the SSR development application
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/components-dev/ssr/server.ts |
Minor formatting improvement to inline comment |
packages/components-dev/ssr/main.ts |
Refactored to import and use shared config instead of inline providers |
packages/components-dev/ssr/main.server.ts |
Refactored to import server config; however, introduces incorrect API usage with BootstrapContext |
packages/components-dev/ssr/config.ts |
New file containing shared application configuration for client and server |
packages/components-dev/ssr/config.server.ts |
New file merging base config with server-specific providers; missing event replay configuration |
packages/components-dev/ssr/README.md |
New documentation file with setup and development instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit f69a3a2): https://koobiq-next--prs-1105-8lxaggnh.web.app (expires Wed, 12 Nov 2025 12:25:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
NikGurev
approved these changes
Nov 12, 2025
lskramarov
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.