Skip to content

fix(split-button): technical debts (#DS-4225)#1114

Merged
lskramarov merged 13 commits into
mainfrom
fix/DS-4225
Nov 20, 2025
Merged

fix(split-button): technical debts (#DS-4225)#1114
lskramarov merged 13 commits into
mainfrom
fix/DS-4225

Conversation

@lskramarov

@lskramarov lskramarov commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@lskramarov lskramarov self-assigned this Nov 11, 2025
@github-actions

github-actions Bot commented Nov 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 3abbd7e):

https://koobiq-next--prs-1114-c45gkjfh.web.app

(expires Mon, 24 Nov 2025 13:37:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@lskramarov

lskramarov commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@lskramarov

lskramarov commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

✅ Snapshots updated!

@lskramarov lskramarov marked this pull request as ready for review November 13, 2025 16:39
@lskramarov lskramarov marked this pull request as draft November 13, 2025 16:53
artembelik
artembelik reviewed Nov 14, 2025
View reviewed changes
Comment thread packages/components-dev/split-button/module.ts Outdated
@github-actions

github-actions Bot commented Nov 14, 2025

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Nov 14, 2025

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@lskramarov

lskramarov commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Nov 14, 2025

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Nov 14, 2025

Copy link
Copy Markdown

✅ Snapshots updated!

@lskramarov lskramarov marked this pull request as ready for review November 14, 2025 15:31
@lskramarov lskramarov requested a review from rmnturov November 14, 2025 15:45
@lskramarov lskramarov requested a review from NikGurev November 14, 2025 15:45
NikGurev
NikGurev reviewed Nov 18, 2025
View reviewed changes

@NikGurev NikGurev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сompletely Disabled пример должно быть задизейблены обе части кнопки

NikGurev
NikGurev previously approved these changes Nov 18, 2025
View reviewed changes
NikGurev
NikGurev reviewed Nov 18, 2025
View reviewed changes
Comment thread packages/components/split-button/split-button.ts Outdated
@NikGurev NikGurev self-requested a review November 18, 2025 15:58
@NikGurev NikGurev dismissed their stale review November 18, 2025 15:59

found a reasonable question

@rmnturov

rmnturov commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Подготовил в фигме такую же раскладку всех состояний, как в коде для тестов
https://www.figma.com/design/sHcbGrJoOZmFA0DsJQIer9/%F0%9F%9F%A5-koobiq-%C2%B7-components?node-id=59455-64205&t=b5K9EVUVXi8lef2n-4
изображение

@rmnturov

rmnturov commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

По ховеру на неактивную основную кнопку не надо скрывать разделитель
Clipboard-20251119-065310-587

@rmnturov

rmnturov commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

При ховере, эктиве 
и фокусе на вторую кнопку 
должен пропадать разделитель

@rmnturov

rmnturov commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

фокус обрезается некрасиво
изображение

@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@lskramarov

lskramarov commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown

✅ Snapshots updated!

@lskramarov lskramarov merged commit f8f75d5 into main Nov 20, 2025
8 checks passed
@lskramarov lskramarov deleted the fix/DS-4225 branch November 20, 2025 06:20
artembelik pushed a commit that referenced this pull request Nov 20, 2025
@lskramarov @artembelik
fix(split-button): technical debts (#DS-4225) (#1114)
3a0c665 
Co-authored-by: lskramarov <9027254+lskramarov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artembelik artembelik artembelik approved these changes
@rmnturov rmnturov rmnturov approved these changes
@NikGurev NikGurev NikGurev approved these changes

Assignees

@lskramarov lskramarov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lskramarov @rmnturov @artembelik @NikGurev