fix: missed component class name 'kbq-' prefix (#DS-3753)#1116
Merged
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CSS class naming by adding the required 'kbq-' prefix to component class names that were previously non-compliant with the project's naming convention. This resolves issue #DS-3753.
- Standardizes CSS class naming across components by adding the 'kbq-' prefix
- Removes temporary stylelint-disable comments that were added as placeholders for this fix
- Updates all corresponding templates, tests, and snapshots to match the new class names
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/docs-examples/components/breadcrumbs/breadcrumbs-truncate-center-items/breadcrumbs-truncate-center-items-example.ts | Updated ellipsis center class names with kbq- prefix |
| packages/components/toggle/toggle.scss | Removed stylelint-disable and added kbq- prefix to toggle position classes |
| packages/components/toggle/toggle.component.html | Updated class bindings to use prefixed class names (kbq-toggle_left, kbq-toggle_right) |
| packages/components/scrollbar/scrollbar.component.scss | Removed global stylelint-disable, kept per-line disables for external library classes |
| packages/components/modal/modal.scss | Removed stylelint-disable and added proper inline disables for deprecated classes |
| packages/components/markdown/markdown.scss | Added kbq-markdown__ prefix to internal class names |
| packages/components/markdown/markdown.component.ts | Updated template class names to match SCSS changes |
| packages/components/markdown/_markdown-theme.scss | Removed unnecessary blank lines |
| packages/components/markdown/snapshots/markdown.component.spec.ts.snap | Updated snapshots to reflect new class names |
| packages/components/file-upload/single-file-upload.component.scss | Removed stylelint-disable and added kbq-file- prefix to component classes |
| packages/components/file-upload/single-file-upload.component.html | Updated template to use prefixed class names |
| packages/components/file-upload/multiple-file-upload.component.scss | Added kbq-file- prefix to all component classes and replaced ngClass with individual class bindings |
| packages/components/file-upload/multiple-file-upload.component.html | Updated template with prefixed classes and replaced ngClass with class bindings |
| packages/components/file-upload/file-upload.spec.ts | Updated test selectors to match new class names |
| packages/components/file-upload/file-upload.scss | Added kbq- prefix to ellipsis and dropzone classes |
| packages/components/file-upload/file-upload.karma-spec.ts | Updated test selectors with new class names |
| packages/components/file-upload/file-drop.ts | Added static class and renamed dragover to kbq-file-drop_dragover |
| packages/components/file-upload/file-drop.spec.ts | Updated test expectations for new dragover class name |
| packages/components/file-upload/_file-upload-theme.scss | Removed stylelint-disable and updated all class references with kbq- prefix |
| packages/components/ellipsis-center/ellipsis-center.directive.ts | Updated element selectors to use kbq-ellipsis-center_ prefix |
| packages/components/ellipsis-center/ellipsis-center.directive.spec.ts | Updated test selectors for new class names |
| packages/components/core/styles/typography/_typography.scss | Removed stylelint-disable and added kbq-md- prefix to markdown typography classes |
| packages/components-dev/file-upload/module.ts | Updated dragover class name and exported DevExamples component |
| packages/components-dev/e2e/components/file-upload.ts | Updated dragover class name in E2E tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit bcf2c0e): https://koobiq-next--prs-1116-q38hfem0.web.app (expires Sat, 22 Nov 2025 13:27:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
NikGurev
reviewed
Nov 12, 2025
NikGurev
left a comment
NikGurev
left a comment
Contributor
There was a problem hiding this comment.
file-upload - 🆗 /❔ (с большей частью изменений согласен, но не хотелось бы чтобы заводили баг, что что-то кастомное сломалось, т.е. делаем на свой страх и риск)
markdown - 🆗
toggle - 🆗
ellipsis-center - 🆗
lskramarov
approved these changes
Nov 18, 2025
NikGurev
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.