Skip to content

fix(modal,sidepanel): content body top padding (#DS-2557)#1128

Merged
artembelik merged 2 commits into
mainfrom
fix/DS-2557
Nov 25, 2025
Merged

fix(modal,sidepanel): content body top padding (#DS-2557)#1128
artembelik merged 2 commits into
mainfrom
fix/DS-2557

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 19, 2025 13:20
@artembelik
artembelik requested a review from NikGurev as a code owner November 19, 2025 13:20
@artembelik artembelik self-assigned this Nov 19, 2025
@artembelik artembelik added the bug Something isn't working label Nov 19, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes content body top padding issues in modal and sidepanel components by adding a minimal 1px top padding. This padding prevents CSS margin collapse between the content body and its child elements, ensuring consistent spacing.

  • Changed modal content top padding from 0 to 1px via CSS variable
  • Added 1px top padding to sidepanel body element

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/components/modal/modal-tokens.scss Updated --kbq-modal-size-content-padding-top CSS variable from 0 to 1px to prevent margin collapse
packages/components/sidepanel/sidepanel.scss Added padding-top: 1px to .kbq-sidepanel-body to prevent margin collapse

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/sidepanel/sidepanel.scss Outdated
@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 36e9c24):

https://koobiq-next--prs-1128-c5szk7fe.web.app

(expires Sat, 29 Nov 2025 10:05:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Comment thread packages/components/sidepanel/sidepanel.scss Outdated
@lskramarov
lskramarov requested a review from rmnturov November 20, 2025 12:05
@lskramarov

Copy link
Copy Markdown
Contributor

Еще поповер.

@lskramarov
lskramarov self-requested a review November 20, 2025 12:16
Comment thread packages/components/modal/modal-tokens.scss
@rmnturov

Copy link
Copy Markdown
Contributor

в поповере еще можно

@rmnturov

Copy link
Copy Markdown
Contributor
изображение

@artembelik

Copy link
Copy Markdown
Contributor Author

Еще поповер.

в поповере еще можно

в нем уже есть отступ, добавил комментарий

@artembelik
artembelik merged commit 2471875 into main Nov 25, 2025
8 checks passed
@artembelik
artembelik deleted the fix/DS-2557 branch November 25, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants