Skip to content

fix(title): center tooltip on the trigger instead of edge-anchoring (#DS-2561)#1670

Merged
lskramarov merged 1 commit into
mainfrom
fix/DS-2561
Jul 1, 2026
Merged

fix(title): center tooltip on the trigger instead of edge-anchoring (#DS-2561)#1670
lskramarov merged 1 commit into
mainfrom
fix/DS-2561

Conversation

@lskramarov

Copy link
Copy Markdown
Contributor

No description provided.

@lskramarov lskramarov self-assigned this Jun 30, 2026
@lskramarov lskramarov added the bug Something isn't working label Jun 30, 2026
@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 6e3eaa1):

https://koobiq-next--prs-1670-fslq0p3r.web.app

(expires Sun, 05 Jul 2026 15:15:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates kbq-title tooltip positioning so that when the default placement (top) can’t be used, the directive falls back only to center-aligned placements (top/bottom/right/left) instead of allowing corner/edge-anchored placements (e.g. topLeft, topRight, etc.). This aligns the title tooltip visually with the trigger’s center rather than its edges.

Changes:

  • Adds a default placementPriority for KbqTitleDirective (only when consumers haven’t provided kbqPlacementPriority and the placement is the default top).
  • Uses PopUpPlacements constants to define the center-aligned fallback order.
  • Adds unit tests verifying the new default priority behavior and that explicit consumer configuration is respected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/components/title/title.directive.ts Sets a default center-only placementPriority for the title tooltip when using the default placement.
packages/components/title/title.directive.spec.ts Adds test coverage for the new default placementPriority behavior and explicit override cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lskramarov lskramarov merged commit 6c3e55a into main Jul 1, 2026
10 checks passed
@lskramarov lskramarov deleted the fix/DS-2561 branch July 1, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants