promotepolicy crd and controller for application migrate #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosmos-robot
requested review from
ONE7live,
OrangeBao,
wangyizhi1 and
wuyingjun-lucky
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhouhaoA1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: renxiangyu <[email protected]> Signed-off-by: zhouhaoA1 <[email protected]>
Signed-off-by: zhouhaoA1 <[email protected]>
Signed-off-by: renxiangyu <[email protected]> Signed-off-by: zhouhaoA1 <[email protected]>
Signed-off-by: zhouhaoA1 <[email protected]>
|
@duanmengkk please help reivew it |
Signed-off-by: renxiangyu <[email protected] Signed-off-by: zhouhaoA1 <[email protected]>
|
PLZ add some e2e tests and resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
crd and controller for application migrate
Which issue(s) does this PR fix?
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?