Skip to content

Conversation

@justinsb
Copy link
Contributor

Better define the error when a function is not found, and use this to
support multiple engines.

Better define the error when a function is not found, and use this to
support multiple engines.
Copy link
Contributor

@martinmaly martinmaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droot may want to approve the change to pkg/fn

I suggested to @mengqiy in his PR #2934 to move the error here as well so we will need to de-dupe

@mengqiy
Copy link
Contributor

mengqiy commented Mar 25, 2022

This PR has some overlapping with my PR in #2934
I can rebase myPR on this PR, if it merges soon.

@mengqiy
Copy link
Contributor

mengqiy commented Mar 26, 2022

@justinsb I cherry-picked your commit in my PR and fixed the CI failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants