Use region ISO3 instead of name for data fetching - #131
Merged
Merged
Conversation
tuyenhn
commented
Jun 4, 2026
tuyenhn
left a comment
tuyenhn
left a comment
Collaborator
Author
There was a problem hiding this comment.
self-reviewed and this all looks ok
it is also backwards-compatible and should not result in any breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initialising a
ReanalysisSingleLevelsobject, if the region name isn't a valid ISO3 value, set thename_without_adminto the ISO3 value instead. This allows subsequent checks for existing data to match against the parent ISO3.This also means the user must make sure that the custom region is a subregion of its ISO3 parent region.
Dependency of kraemer-lab/DART-Pipeline#335