Skip to content

Patches and fixes for custom admin region - #133

Merged
tuyenhn merged 8 commits into
mainfrom
use-iso3-for-data-fetching
Jun 15, 2026
Merged

tuyenhn merged 8 commits into
mainfrom
use-iso3-for-data-fetching

Conversation

@tuyenhn

@tuyenhn tuyenhn commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@tuyenhn

tuyenhn commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

@quingzz is this good to go?

Can you help list out a summary of changes you made for documentation and archival purposes

@quingzz

quingzz commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Sure!

The changes made includes

  • Changing pk, admin_files attributes of Region class from dict to tuple so that Region object is hashable, which is needed for caching in downstream dart-pipeline workflows
  • Adding new test cases for user defined shapefiles configured via regions.toml

@tuyenhn

tuyenhn commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Pinging @abhidg, what do you think?

uvx nox passes so the changes are backward-compatible, shouldn't have any breaking changes

@abhidg abhidg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @quingzz!

Comment thread src/geoglue/region.py Outdated
@tuyenhn
tuyenhn merged commit e83cf4e into main Jun 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants