Bugfix for DI#37
Merged
Merged
Conversation
Refactored AddBusinessCentral to use AddHttpClient<IBusinessCentralClient>() for improved flexibility and best practices. Updated tests to resolve BusinessCentralClient directly and assert interface implementation, enhancing DI correctness and maintainability.
Refactored BusinessCentralClient and service registration to use Microsoft.Extensions.Options for BusinessCentralOptions configuration and validation. Improved AddBusinessCentral to validate options on startup and register both client and interface with HttpClient. Updated tests and observer registration for consistency. Bumped package version to 1.0.0-beta2.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Refactor to align dependency injection and configuration with .NET options pattern.
PR Summary
This pull request updates the registration and injection of BusinessCentralOptions to use Microsoft.Extensions.Options, improving configuration management and DI consistency.