First-ten audit maintenance: CI concurrency, Greptile scopes and context, wait exit tests

[krishhgg]

Each master commit gets its own CI run, Greptile checks more of the wire-reading and CLI code, and three integration tests cover attention, failed-run and timeout outcomes. This completes the warranted CI/config changes from Astra and Fable's first-ten audit.

Sol passed formatting, strict Clippy and all 296 tests at d21868c: 274 library, 2 main, 12 CLI and 8 fake-RPC tests. The final b3d3796 changes only Greptile prose/scope and the audit record; its source, tests and workflow are identical. The diff check and Greptile JSON/context validation pass. Final CI passed on b3d3796. Greptile reviewed that same commit, gave it 5/5 and found no actionable issue.

Decision log

What I noticed

Astra and Claude Fable 5.1, both at xhigh, independently audited sprint PRs #8 through #17. They found cancelled master CI runs, gaps in Greptile's protocol/cost coverage and missing CLI wait outcomes. The context file still called an earlier proposal the agreed plan.

How I confirmed it

Sol checked all ten cancelled master runs from #8 through #21; none had a job. The CLI tests run the actual binary with temporary homes and fake HTTP, WebSocket and auth endpoints. Plain and JSON cases verify exits 7, 1 and 6, partial replies, exactly one JSON result, and the timeout's sent message ID. Sol also verified master's ruleset now requires macOS and Greptile Review.

Options

Group PR runs by number and master runs by commit SHA. Keeping one master group still replaces pending runs even when cancellation is off. Expand the existing protocol and idle-cost rules, and use README for current commands, the parity documents for the pinned baseline and source references, and sprint.md for progress. Reuse the existing fake-server harness. A queue redesign or new testing framework was unnecessary.

What review changed

Sol reconciled both audits. #20 had already fixed repeated handoff descriptions, so this PR leaves that code alone. Sol added models.rs to protocol coverage and corrected reconnect guidance: shell/thread streams resume with afterSequence; config subscriptions use an empty request and a fresh snapshot. Claude kept #22's changes when bringing master into this branch. The audit record tracks 15 merged sprint PRs and the next audit at 20. Greptile's final review found no actionable issue.

Known limits

This changes no product code or TUI layout. The raw-control-character gap in plain CLI output needs a separate maintenance PR. Attention coverage exercises a command approval, not a pending question. The timeout test takes about two seconds across its two runs. Failed-run JSON retains the existing ok: true and outcome: "failed" contract. Maintenance PRs do not count toward the next audit.

Confidence Score: 5/5

This PR appears safe to merge; no actionable issue was found.

Summary

This PR updates CI grouping, review guidance, and CLI wait tests without changing product code.

• Each master commit gets its own CI run group.
• Greptile checks more of the code that reads server data and CLI streams.
• CLI integration tests cover approval, failure, and timeout outcomes.

Acknowledgments supplied by krishhgg:

• Raw control characters in existing plain CLI output are deferred to a separate maintenance PR.
• Attention coverage intentionally tests command approval, not a pending question.
• Failed-run JSON intentionally keeps ok: true with outcome: "failed".
• The timeout test intentionally takes about two seconds across its two runs.

_{Reviews (1) · Last reviewed commit: "greptile: cover models.rs and state each..." · Reviewed by Greptile}