Add support for accent color saturation level #49
Conversation
|
This does not mean it does not work on Windows Vista to 10, in fact, it should work as intended. My main concern was Windows 11. |
|
I just realized that we forked the project almost at the same time lol. |
|
@OrthodoxWindows Try out my new version, you'll like it. |
| if (message == WM_DWMCOLORIZATIONCOLORCHANGED || (message == WM_WTSSESSION_CHANGE && wParam == WTS_SESSION_UNLOCK)) { | ||
| accentColorChanges++; | ||
| } | ||
| else { |
There was a problem hiding this comment.
Don't we need to re-apply colorization if theme has been changed (WM_THEMECHANGED)? I'm not sure, just wondering
There was a problem hiding this comment.
This is used when you change the accent color in order to find your previous saturation. You can check AccentColorHelper.cpp for why I'm using it.
Indeed, your changes fix all the problems I was having. Thank you very much. However, I still see one element not colorized ; these are some frames related to the Basic theme (if you use the Basic theme with DWM, you have to use this Windhawk mod to enable them) in the Aerolite style : For some reason, in the Aero style, it seems to be colorized correctly : |
|
@krlvm This one has full HSL support, meaning the bitmaps change according to the different brightness levels of accent colors. It fully works on the Rectify11 visual styles (light and dark), but on the Microsoft ones (Windows 10/11), the Explorer list views do not support all colors and may turn into weird colors. I thought it was the transparent pixels but they colorize perfectly with the Rectify11 styles. I tried multiplying the saturation by 0.9 and that workaround works but the colors are more inaccurate. |
|
This is still very cool, I'll think about how I can help this evening and we'll merge it into the upstream |
|
Have you checked the code? |
|
Currently it breaks with light orange color: |
|
(just for record, will check what we can do with it) |
|
Interestingly enough, the correct colors show up if you have the items grouped and click the expand/collapse button. They only show up when the animation is playing, when it finishes, the broken color comes back. |
The (almost) correct color is also applied to the ListView items focused state |
|
Does this fix the color issue? |
|
Yes, it works much better. Thank you! However, if you set accent color back to Standard Blue, everything looks undersaturated in comparasion to the default colors - where did you get |
|
This is almost perfect, its only bug is when the theme is changed, it applies a weird light gray color and changing the accent color to a normal one gives wrong lightness values and gradients are completely ruined. |
| accentColorChanges = 1; | ||
| } | ||
| else if (message == WM_DWMCOLORIZATIONCOLORCHANGED || (message == WM_WTSSESSION_CHANGE && wParam == WTS_SESSION_UNLOCK)) { | ||
| accentColorChanges = 2 + accentColorChanges; |
There was a problem hiding this comment.
To be able to use the g_oldhslAccentS and g_oldhslAccentL values, these should not be used on the first time you launch the program, only when the accent color is changed
|
|
I just kill and start the process again, so it recolorizes everything one more time |
|
You can also change accent colors back and forth a few times and then check the produced color with a graphics editor - it will change |
Yes, I have not addressed this issue. I always assumed users would start it once until they restart the device (which resets bitmaps back to default colors). I guess we can save the |
Is it a big difference in the colors? I mean back then it was very easy to notice but I've improved the accuracy over time -- I know it is not 100% perfect but it's still very close. I guess it's fractional imperfections in the RGB to HSL logic |
|
We can store currently applied accent color in registry |
|
Why do we need to store the accent color? We only need to store |
|
Yes, that's what I meant, but we can also store the color itself to avoid re-application |
Have you tried to change the theme (visual style)? Changing from Windows default to High Contrast and back to Windows default is enough -- no custom visual style needed. You'd also need a desaturated accent color (like the "Iris pastel" or "Camouflage desert" colors in the Windows presets) to notice it. The saturation is ignored and lightness is inaccurate when I use Release but that doesn't happen on Debug |
|
@krlvm Now that I tried launching the release build from VS itself, |
|
It looks like it doesn't apply the saturation and lightness changes when the theme is changed, but does when you change the accent color after that (on Release). On Debug, everything is done correctly. Why does Release ignore them at theme change? |
What's the sequence? Switch to a high contrast theme, go back and change the accent color? |
Yes, also, the accent color prior to theme change should be desaturated (like "Iris pastel" or "Camouflage desert" from the Windows presets) |
|
I can't reproduce it on Windows 10 neither on Release nor on Debug builds, do you use Windows 11? |
|
Yes I use Windows 11, I also tried on 3 different visual styles. Did you use one of the colors I asked you to use? |
|
Yes, I did with both colors. Maybe it's a Windows 11 specific problem, I'll get a VM and check. |
I don't know. If you wonder what build I'm running, it's 22621.382 |
|
@krlvm Have you tested it on Windows 11? |
However, many Aerolite style elements do not use bitmaps, yet they are correctly colorized. Its strange. |
They use ColorList. ColorList is not the same as FillColor. |
Thank you, I understand better. While exploring the visual style, I noticed that elements that use FillColor are rare. |
I haven't had time yet, but I'll try soon |
|
@krlvm Have you done any further tests? It's been 2 months |
|
Update: Behavior is different on a more updated 22621 build. Changing themes now gives a half-saturated default accent color. |
|
@krlvm I think I fixed almost everything here, the only remaining thing is how to properly support colorization if the theme was already colorized, e.g. when the user quickly signs out and back in, the colorized theme is still loaded in memory, and AccentColorizer would reapply that colorization, leading to wrong saturation and brightness. Same thing could happen if the user terminates the process and re-executes it. |
|
@WinExperiments is your version the latest version of this software? |
|
@Flameancer Yes it is. I cannot contact the original developer anymore. |
This new version allows you to use any accent color, such as gray, brown, etc. Designed to colorize the default Windows 11 visual style and Rectify11's custom visual styles. Does not have the Windows version checks apart from the taskband ExtendedUI buttons.