Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement KRO Labels For RGD CRDs #282

Merged

Conversation

Gonfidel
Copy link
Contributor

@Gonfidel Gonfidel commented Feb 8, 2025

In relation to issue #185, we should add KRO management labels to CRD's created via ResourceGraphDefinitions.

Example label output from example/webapp/rg.yaml

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  creationTimestamp: "2025-02-08T04:53:40Z"
  generation: 1
  labels:
    kro.run/controller-pod-id: kro-pod
    kro.run/kro-version: 0.2.1
    kro.run/owned: "true"
    kro.run/resource-graph-definition-id: f25ffd07-df0c-4c7e-b90e-507c80d317fc
    kro.run/resource-graph-definition-name: webapp.kro.run
  name: webapps.kro.run
  resourceVersion: "33637"
  uid: 0e3fdd78-bafe-4bca-b44e-9cb6e23dce58

@Gonfidel Gonfidel changed the title gonfidel/implement_kro_labels_for_rgd_crds gonfidel/implement-kro-labels-for-rgd-crds Feb 8, 2025
@Gonfidel Gonfidel changed the title gonfidel/implement-kro-labels-for-rgd-crds Implement-kro-labels-for-rgd-crds Feb 8, 2025
@Gonfidel Gonfidel changed the title Implement-kro-labels-for-rgd-crds Implement KRO Labels For RGD CRDs Feb 8, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks a lot @Gonfidel !
/lgtm

@a-hilaly a-hilaly merged commit 198927f into kro-run:main Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants