Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom functions #375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support custom functions #375

wants to merge 2 commits into from

Conversation

HeeManSu
Copy link

@HeeManSu HeeManSu commented Mar 11, 2025 •
edited
Loading

#361

  • Implement support for custom functions
  • Write tests
  • Update docs

@HeeManSu
Copy link
Author

@fsommar Can you please check the implementation?

fsommar
fsommar reviewed Mar 11, 2025
View reviewed changes
pkg/cel/function/function.go
Comment on lines +101 to +104
case "list":
return cel.ListType(cel.AnyType), nil
case "map":
return cel.MapType(cel.StringType, cel.AnyType), nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're ok with making backwards incompatible changes to this (@a-hilaly your input please), we can start including list and map. If not, I suggest we start with just the primitives and add support for lists and maps later, probably when the design for complex types #144 is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsommar fsommar fsommar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeeManSu @fsommar