allow tips to be submitted directly to wallets. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallet is obviously skipped on notices. this should still work for amplifications too.
removes inline type and length checks that were strewn around. will allow for better / more flexible validation alround.
|
Thanks, please add some checking of the address. 99 chars, starts with TRTL. Invalid address tx will just be cancelled eventually (or don't go through at all idk) so that should be good enough. |
|
Funny you said that, I literally just implemented this before reading your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I heard someone was asking for this.
notes:
{}tip <amount> <address> <message>, and no mentions.