-
Notifications
You must be signed in to change notification settings - Fork 150
Fix list branch query #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kuzminT, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with the ListBranches method by correctly implementing the q (query) parameter for filtering branches. It also enhances the codebase with new unit tests for this functionality and updates documentation. The author has noted that automatic pagination is not yet included but could be integrated in a follow-up.
Highlights
- Branch Listing Query Fix: The ListBranches method in repository.go now correctly formats the q parameter for filtering branches, using the Bitbucket API's name ~ "query" syntax instead of a simple string match.
- Unit Test Addition: A new unit test, TestListBranches, has been added to tests/repository_test.go to ensure the proper functioning of the ListBranches method, including its query capabilities.
- Dependency Modernization: The ioutil.ReadAll function has been replaced with io.ReadAll in repository.go, aligning with modern Go practices for reading from io.Reader interfaces.
- Gitignore Update: The .gitignore file was updated to exclude .idea and .env directories, preventing common development environment files from being tracked by Git.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue with the q
(query) parameter in the ListBranches
method, adds documentation, and a new unit test. The change correctly formats the query for the Bitbucket API. However, there's a potential issue with URL encoding of the ~
operator which I've highlighted. The new test is a good start, but I've suggested improvements to make it more robust. The update from ioutil
to io
is a good practice.
Refers to #312.
q
(query) parameter in theListBranches
method.ListBranches
.executePaginated
is not yet implemented. Supporting it requires refactoring thedecodeRepositoryBranches
method to use a different format. I can include these changes in this PR if that’s fine.