-
Notifications
You must be signed in to change notification settings - Fork 2
Add extraObjects and kubecost PR testing workflow #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6f3d456
chart tests
jessegoodier 868d8b4
add tests
jessegoodier 8801327
Potential fix for code scanning alert no. 1: Workflow does not contai…
jessegoodier d850603
remove markdown
jessegoodier 17e38f1
remove yamllint
jessegoodier 1a56b2a
v1
jessegoodier a502337
change versions
jessegoodier 329d755
formatting
jessegoodier 143e69d
rename
jessegoodier a7b5685
2.7
jessegoodier 17e48db
2.7.1
jessegoodier d778578
2.7.0
jessegoodier 5dece71
formatting (testing)
jessegoodier a751862
formatting
jessegoodier 375bf5a
remove unsupported image.debug
jessegoodier a164b6b
kind test cluster
jessegoodier 69fdc37
unused file
jessegoodier d13a8b1
add extraObjects
jessegoodier 3f92d4f
fix env var
jessegoodier 76bdd67
formatting
jessegoodier 54abdb6
fix path
jessegoodier 27b0cda
cancel-in-progress
jessegoodier 6da354c
rename job
jessegoodier 640c7a8
fix path
jessegoodier 0c038d8
Merge branch 'main' into add-tests
jessegoodier 1ecf376
Merge branch 'main' into add-tests
jessegoodier bb6fb86
formatting
jessegoodier 084b817
ct config for helm validation
jessegoodier e70bf7a
helm validation workflow
jessegoodier d6c7a1d
pin python to 3.13
jessegoodier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| # Default state for all rules | ||
| default: true | ||
|
|
||
| # MD013/line-length - Line length | ||
| MD013: | ||
| # Number of characters | ||
| line_length: 120 | ||
| # Allow long code blocks | ||
| code_blocks: false | ||
| # Allow long tables | ||
| tables: false | ||
|
|
||
| # MD024/no-duplicate-heading - Multiple headings with the same content | ||
| MD024: | ||
| # Allow different nesting levels to use same heading text | ||
| allow_different_nesting: true | ||
|
|
||
| # MD033/no-inline-html - Inline HTML | ||
| MD033: | ||
| # Allow specific HTML elements | ||
| allowed_elements: | ||
| - br | ||
| - img | ||
|
|
||
| # MD041/first-line-heading - First line in a file should be a top-level heading | ||
| MD041: | ||
| # Exclude files that are likely to be included in other files | ||
| exclude: | ||
| - _*.md | ||
|
|
||
| # Made with Bob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| extends: default | ||
|
|
||
| rules: | ||
| # 80 chars should be enough, but don't fail if a line is longer | ||
| line-length: | ||
| max: 120 | ||
| level: warning | ||
|
|
||
| # Accept both Unix-style and Windows-style line endings | ||
| new-line-at-end-of-file: enable | ||
|
|
||
| # Enforce document start with --- | ||
| document-start: | ||
| present: true | ||
|
|
||
| # Spaces, not tabs | ||
| indentation: | ||
| spaces: 2 | ||
| indent-sequences: consistent | ||
|
|
||
| # No trailing spaces | ||
| trailing-spaces: enable | ||
|
|
||
| # Ensure consistent empty lines | ||
| empty-lines: | ||
| max: 2 | ||
| max-start: 0 | ||
| max-end: 0 | ||
|
|
||
| # Enforce key ordering | ||
| key-ordering: disable | ||
|
|
||
| # Quotes are not required for all strings in YAML | ||
| quoted-strings: | ||
| quote-type: any | ||
| required: only-when-needed | ||
|
|
||
| # Made with Bob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| --- | ||
| name: PR Validation | ||
|
|
||
| on: | ||
| pull_request | ||
|
|
||
| jobs: | ||
| lint-test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up Helm | ||
| uses: azure/setup-helm@v4.3.1 | ||
| with: | ||
| version: "" # latest version | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.x' | ||
| check-latest: true | ||
|
|
||
| - name: Set up chart-testing | ||
| uses: helm/chart-testing-action@v2.7.0 | ||
|
|
||
| - name: Run chart-testing (list-changed) | ||
| id: list-changed | ||
| run: | | ||
| changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }}) | ||
| if [[ -n "$changed" ]]; then | ||
| echo "changed=true" >> "$GITHUB_OUTPUT" | ||
| fi | ||
|
|
||
| - name: Run chart-testing (lint) | ||
| if: steps.list-changed.outputs.changed == 'true' | ||
| run: ct lint --target-branch ${{ github.event.repository.default_branch }} | ||
|
|
||
| - name: Create kind cluster | ||
| if: steps.list-changed.outputs.changed == 'true' | ||
| uses: helm/kind-action@v1.12.0 | ||
|
|
||
| - name: Run chart-testing (install) | ||
| if: steps.list-changed.outputs.changed == 'true' | ||
| run: ct install --target-branch ${{ github.event.repository.default_branch }} | ||
|
|
||
| markdown-lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Lint Markdown files | ||
| uses: DavidAnson/markdownlint-cli2-action@v13 | ||
| with: | ||
| globs: '**/*.md' | ||
| config: '.github/linters/markdownlint.yaml' | ||
|
|
||
| whitespace-check: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.x' | ||
|
|
||
| - name: Install yamllint | ||
| run: pip install yamllint | ||
|
|
||
| - name: Check YAML files with yamllint | ||
| run: | | ||
| yamllint -d "{extends: default, rules: {trailing-spaces: {}, document-end: {present: true}}}" charts/ | ||
|
|
||
| - name: Check for trailing whitespace in MD and TPL files | ||
| run: | | ||
| if grep -r --include="*.md" --include="*.tpl" "[[:blank:]]$" charts/; then | ||
| echo "Error: Found trailing whitespace in .md or .tpl files" | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Check for missing newlines in MD and TPL files | ||
| run: | | ||
| exit_code=0 | ||
| for file in $(find charts/ -type f -name "*.md" -o -name "*.tpl"); do | ||
| if [ -s "$file" ] && [ "$(tail -c 1 "$file" | wc -l)" -eq 0 ]; then | ||
| echo "Error: $file does not end with a newline" | ||
| exit_code=1 | ||
| fi | ||
| done | ||
| exit $exit_code | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.