-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): support volume mount in tune API #2508
base: master
Are you sure you want to change the base?
feat(sdk): support volume mount in tune API #2508
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a2d2c5f
to
898d047
Compare
898d047
to
222020d
Compare
a0fbd20
to
ec38767
Compare
@truc0 Amazing! Thanks for doing this. And I'm sorry for the late reply. I'll review this PR in this week. cc @kubeflow/wg-automl-leads @helenxie-bit @mahdikhashan |
@truc0 thank you - would you please add unit tests and e2e for your changes - unit tests in this path: I'll review the code and functionality after it. thanks for your time. |
Sure, I will add it soon |
Signed-off-by: truc0 <[email protected]>
ec38767
to
a005199
Compare
What this PR does / why we need it:
As discussed on #2247 , providing a clean and simple way for specifying volume mount in
tune
API of katib Python SDK will enhance develop experience.This PR adds
storage_per_trial
argument toKatibClient.tune()
method.Design
The
storage_per_trial
argument is designed to have the following type:To simplify the usage, there are some enhancements:
storage_per_trial
to:Union[TuneStoragePerTrial, List[TuneStoragePerTrial]]
dict
instead of aclient.V1Volume
object when the storage config is simple:mount_path
with astr
instead ofclient.V1VolumeMount
Example Usage
Full Example
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2247
Checklist:
storage_per_trial