Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): update python from 3.7 to 3.12 #10950

Closed

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Jun 24, 2024

Description of your changes:

Follow up of #10750
@rimolive @chensun @rickyxie0929 @connor-mccarthy

@rickyxie0929 @rimolive this is a fast draft, i can add you to my pipelines for if you want to add changes here.

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -11,7 +11,7 @@ spec:
spec:
containers:
- name: profile-controller
image: python:3.7
image: python:3.12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially this old python here is a security risk.

@juliusvonkohout juliusvonkohout changed the title update python from 3.7 to 3.12 chore(sdk): update python from 3.7 to 3.12 Jun 24, 2024
@juliusvonkohout juliusvonkohout changed the title chore(sdk): update python from 3.7 to 3.12 chore(backend): update python from 3.7 to 3.12 Jun 24, 2024
@juliusvonkohout
Copy link
Member Author

We could also go to 3.11 first if that helps.

@juliusvonkohout
Copy link
Member Author

/retest-required

Copy link

google-oss-prow bot commented Jun 24, 2024

@juliusvonkohout: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test a6d551a link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipelines-samples-v2 a6d551a link false /test kubeflow-pipelines-samples-v2
kubeflow-pipelines-components-google-cloud-python38 a6d551a link true /test kubeflow-pipelines-components-google-cloud-python38
kubeflow-pipelines-sdk-python310 a6d551a link true /test kubeflow-pipelines-sdk-python310
kubeflow-pipelines-sdk-python38 a6d551a link true /test kubeflow-pipelines-sdk-python38
kubeflow-pipelines-sdk-python39 a6d551a link true /test kubeflow-pipelines-sdk-python39
kubeflow-pipelines-sdk-python311 a6d551a link true /test kubeflow-pipelines-sdk-python311
kfp-kubernetes-execution-tests a6d551a link false /test kfp-kubernetes-execution-tests
kubeflow-pipelines-sdk-python312 a6d551a link true /test kubeflow-pipelines-sdk-python312

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Jun 25, 2024

CVE Scanning
Automatic CVE scanning with Trivy on the master branch is relevant for DevSecOps and enterprise security guidelines https://github.com/kubeflow/manifests/blob/master/.github/workflows/trivy.yaml
Here are some numbers from June 25 https://github.com/kubeflow/manifests/actions/runs/9658715319/job/26640495132
I need someone independent to verify the script and numbers.

Working Group Images Critical CVE High CVE Medium CVE Low CVE
AutoML 13 15 231 547 756
Pipelines 45 204 1909 7342 3236
Workbenches(Notebooks) 12 26 222 315 230
Kserve 13 43 522 1986 1418
Manifests 18 19 18 174 78
Training 1 1 1 1 0
Model Registry 3 18 71 104 147
All Images 105 326 2974 10469 5865

@rimolive
Copy link
Member

@juliusvonkohout Can you please rebase?

Signed-off-by: juliusvonkohout <[email protected]>
@juliusvonkohout
Copy link
Member Author

@rimolive rebase is done

@hbelmiro
Copy link
Contributor

@juliusvonkohout what about the failing tests? They are not optional.

@juliusvonkohout
Copy link
Member Author

@diegolovison will probably continue this PR. I gave him access to the branch.

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Sep 2, 2024

Will be continued in #11159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants