-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][backend] Add workflow to validate affected generated files #11539
Conversation
Hi @chahatsagarmain. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
cc @DharmitD |
/ok-to-test |
Approvals successfully granted for pending runs. |
@chahatsagarmain can you address the ci failures? |
2202529
to
ae0dd70
Compare
612fd23
to
2a2029f
Compare
Signed-off-by: chahatsagarmain <[email protected]> Check if there is a difference in generated files Signed-off-by: chahatsagarmain <[email protected]> fix lint Signed-off-by: chahatsagarmain <[email protected]> fix make file Signed-off-by: chahatsagarmain <[email protected]>
2a2029f
to
59f53ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @HumairAK
/lgtm Thanks @chahatsagarmain this is going to save a lot of headache further down the road! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Checklist: