Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][backend] Add workflow to validate affected generated files #11539

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

chahatsagarmain
Copy link
Contributor

Description of your changes:

Checklist:

Copy link

Hi @chahatsagarmain. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

.github/workflows/check-generated-diff.yml Outdated Show resolved Hide resolved
@hbelmiro
Copy link
Contributor

cc @DharmitD

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@HumairAK
Copy link
Collaborator

HumairAK commented Feb 2, 2025

@chahatsagarmain can you address the ci failures?

.github/workflows/check-generated-diff.yml Outdated Show resolved Hide resolved
.github/workflows/check-generated-diff.yml Outdated Show resolved Hide resolved
.github/workflows/check-generated-diff.yml Outdated Show resolved Hide resolved
@chahatsagarmain chahatsagarmain force-pushed the check-diff branch 3 times, most recently from 612fd23 to 2a2029f Compare February 11, 2025 21:32
Signed-off-by: chahatsagarmain <[email protected]>

Check if there is a difference in generated files

Signed-off-by: chahatsagarmain <[email protected]>

fix lint

Signed-off-by: chahatsagarmain <[email protected]>

fix make file

Signed-off-by: chahatsagarmain <[email protected]>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

@HumairAK
Copy link
Collaborator

/lgtm
/approve

Thanks @chahatsagarmain this is going to save a lot of headache further down the road!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 22c3724 into kubeflow:master Feb 12, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Add CI checks for proto generated library validations
3 participants