Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chor(test) : Fix kfp-sdk-test for different python versions #11559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chor(test) : Fix kfp-sdk-test for different python versions #11559

wants to merge 1 commit into from

Conversation

chahatsagarmain
Copy link
Contributor

Description of your changes:
Resolve #11558

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Hi @chahatsagarmain. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chahatsagarmain
Copy link
Contributor Author

@hbelmiro can you run the test once ?

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Jan 28, 2025
@chahatsagarmain chahatsagarmain marked this pull request as draft January 28, 2025 19:33
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@chahatsagarmain
Copy link
Contributor Author

@hbelmiro still working on this , I was running tests on my fork .

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jan 28, 2025
@chahatsagarmain chahatsagarmain marked this pull request as ready for review January 28, 2025 21:21
@google-oss-prow google-oss-prow bot requested a review from DharmitD January 28, 2025 21:21
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

hbelmiro
hbelmiro approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

@google-oss-prow google-oss-prow bot added the lgtm label Jan 29, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbelmiro
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chahatsagarmain
fix
b4cf3fe 
Signed-off-by: chahatsagarmain <[email protected]>

fix test

Signed-off-by: chahatsagarmain <[email protected]>

fix test

Signed-off-by: chahatsagarmain <[email protected]>

fix test

Signed-off-by: chahatsagarmain <[email protected]>

allow class docstring

Signed-off-by: chahatsagarmain <[email protected]>

test

Signed-off-by: chahatsagarmain <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 7, 2025
DharmitD
DharmitD reviewed Feb 7, 2025
View reviewed changes
sdk/python/kfp/cli/utils/parsing.py
raise ValueError(
f'Could not find parameter {param_name} in docstring of {fn}')
f'Could not find parameter {param_name} in docstring of {fn}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, fix EoL here.

@chahatsagarmain
Copy link
Contributor Author

Used some logging to investigate why the test was failing specifically for python 3.13 . The found variable was not being set specifically for python 3.13 . Simplifying the logic to iterate over the method description fixes the issue here .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

@rimolive rimolive Awaiting requested review from rimolive

@DharmitD DharmitD Awaiting requested review from DharmitD

Assignees

@hbelmiro hbelmiro

Labels
ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(<test>): kfp-sdk-tests has an error in the python version variable
3 participants
@chahatsagarmain @hbelmiro @DharmitD