-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(backend): small formatting improvements #11570
Conversation
Hi @dandawg. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
@HumairAK can you please bypass (or re-run) the CI? |
Signed-off-by: Daniel Dowler <[email protected]>
343dc39
to
168b9aa
Compare
Last change was just a rebase since this has sat for a couple of days. |
backend/README.md
Outdated
@@ -9,7 +9,8 @@ This README will help you set up your coding environment in order to build and r | |||
|
|||
## Prerequisites | |||
Before you begin, ensure you have: | |||
- Go programming language installed | |||
- [Go installed](https://go.dev/doc/install) | |||
- [go-licenses tool](../hack/install-go-licenses.sh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we removed this, so we can remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ak! it snuck back in when I did the rebase and had to resolve conflicts. Thanks for catching this.
Signed-off-by: Daniel Dowler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This adds a couple of small formatting changes as a follow-up to PR #11511. The changes were suggested by @HumairAK (thanks Humair!).
Checklist: