-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) : Collect and upload logs when test fails for k8s #11618
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @chahatsagarmain. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chahatsagarmain you missed .github/workflows/upgrade-test.yml
.
Also, could you intentionally introduce an error and create a PR to your fork so we can see the result? You can use a new branch for that to avoid affecting this PR.
b4fb913
to
6db5809
Compare
Signed-off-by: chahatsagarmain <[email protected]> fix: Signed-off-by: chahatsagarmain <[email protected]> add log upload functionality Signed-off-by: chahatsagarmain <[email protected]> changes Signed-off-by: chahatsagarmain <[email protected]> test Signed-off-by: chahatsagarmain <[email protected]> update permission Signed-off-by: chahatsagarmain <[email protected]> update permission Signed-off-by: chahatsagarmain <[email protected]> fail test Signed-off-by: chahatsagarmain <[email protected]> remove exit Signed-off-by: chahatsagarmain <[email protected]> update permission Signed-off-by: chahatsagarmain <[email protected]> update Signed-off-by: chahatsagarmain <[email protected]> update Signed-off-by: chahatsagarmain <[email protected]> add condition Signed-off-by: chahatsagarmain <[email protected]> test Signed-off-by: chahatsagarmain <[email protected]> test Signed-off-by: chahatsagarmain <[email protected]> Remove exit Signed-off-by: chahatsagarmain <[email protected]> test Signed-off-by: chahatsagarmain <[email protected]> fix pod name Signed-off-by: chahatsagarmain <[email protected]> Remove exit Signed-off-by: chahatsagarmain <[email protected]>
24e8716
to
0c31627
Compare
Description of your changes:
Checklist: