WIP: Add backend support for input parameters for k8s fields #11622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change provides sdk support for the following kubernetes platform fields: * configmap name for configmap as env & volume * secret name for configmap as env & volume * image pull secret name It also adds support for tolerations, node selectors as input json for the entire toleration & node selector spec. We opt for this solution because if a user were to try to use as input parameters individual key value pairs, the input parameter count would increase drastically. The implementation borrows the InputParamSpec from the pipeline spec package. This is copied over instead of imported due to cyclic dependency issues with proto imports and the current project structure. Additionally, pvc_mount is updated to accomodate this new spec, which makes it more in line & consistent with how input parameters are handled elsewhere in the spec. Finally, all old name parameter fields like configmap names, secret names, etc. are deprecated, as the runtime value proto message covers this via it's constant field. Signed-off-by: Humair Khan <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold until is merged: #11621 |
HumairAK
changed the title
Signed-off-by: Humair Khan <[email protected]>
This change adds driver support for input parameter support for the kubernetes platform spec. Input resolution change is extracted and made more generic so it may be re-used when buildling out the container spec for the k8s config. The json parameters are unmarshalled into their respective k8s struct. Signed-off-by: Humair Khan <[email protected]>
HumairAK
force-pushed
the
issue-10914-backend
branch
from
b2531fb to
2370789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This is the backend support that depends on the following PR: #11621
Input resolution change is extracted and made more generic so it may be re-used when buildling out the container spec
for the k8s config. The json parameters are unmarshalled into their respective k8s struct.
Checklist: