Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files #11623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muzzlol
Copy link

@muzzlol muzzlol commented Feb 12, 2025

Description of your changes:
Restricted the file explorer to only show .yaml, .yml, .zip, and .tar.gz files instead of all files when selecting pipeline files to improve user experience.

Checklist:

  • The title for your pull request (PR) follows our title convention
  • You have signed off your commits

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @muzzlol. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muzzlol muzzlol force-pushed the fix-file-explorer-filters branch 2 times, most recently from 38cc2eb to 54fd789 Compare February 12, 2025 16:04
@muzzlol
Copy link
Author

muzzlol commented Feb 12, 2025

A lot of validation checks for file types can now be removed from the codebase. I can make those changes, but i feel like i should get confirmation before that. sorry im kinda new to this.

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@muzzlol muzzlol force-pushed the fix-file-explorer-filters branch from 54fd789 to ba4b028 Compare February 13, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants