Skip to content

feat(sdk): adding support for dsl.condition and dsl.parallelFor to local runner #12511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsingla wants to merge 1 commit into
base: master
Choose a base branch
from
+1,548 −385
Open

feat(sdk): adding support for dsl.condition and dsl.parallelFor to local runner #12511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/kfp-sdk-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ concurrency:
jobs:
sdk-tests:
runs-on: ubuntu-latest
timeout-minutes: 40
strategy:
matrix:
python-version: ['3.9', '3.13']
python-version: ['3.11', '3.13']
Comment on lines -25 to +26
Copy link
Contributor

@zazulam zazulam Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for bumping this?

Copy link
Contributor Author

@nsingla nsingla Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we update our minimum supported python version to 3.11 recently, I just did that based on that, but if that's not true, I will revert it back to 3.9

Copy link
Contributor

@zazulam zazulam Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated our images, but we were still testing the sdk against 3.9-3.13. We wanted to make sure that users who were slow to upgrade their python environments wouldn't be cut off from newer sdk releases.


steps:
- name: Checkout code
Expand Down Expand Up @@ -57,7 +58,7 @@ jobs:
sudo systemctl enable docker
sudo usermod -aG docker "$USER"
# Wait for Docker to be ready
timeout 30 bash -c 'until docker info > /dev/null 2>&1; do sleep 1; done'
timeout 5 bash -c 'until docker info > /dev/null 2>&1; do sleep 1; done'
docker info

- name: Run SDK Tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kfp-sdk-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.9', '3.13']
python-version: ['3.11', '3.13']
Copy link
Contributor

@zazulam zazulam Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

@nsingla nsingla Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same reason


steps:
- name: Checkout code
Expand Down
347 changes: 0 additions & 347 deletions sdk/python/kfp/local/dag_orchestrator.py
View file
Open in desktop

This file was deleted.

Loading
Loading