Skip to content

Conversation

@JerT33
Copy link
Contributor

@JerT33 JerT33 commented Dec 4, 2025

(will fix name if PR is taken out of draft)

Description of your changes:

This is a supplemental PR to #12295. The previous PR addressed making error messages less verbose but overlooked that the error details in writeErrorToResponse prints stack traces for errors wrapped by pkg/errors deeper in the call chain

This PR contains the correct implementation and has been validated in a live cluster

Test Evidence:

Before:

Screenshot 2025-12-03 at 11 24 08 PM Screenshot 2025-12-03 at 11 26 21 PM

After:

Screenshot 2025-12-03 at 11 17 05 PM Screenshot 2025-12-03 at 11 16 38 PM

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant