Skip to content

Configurable metadata_service_host domain fixes #12539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajugeorge97 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Configurable metadata_service_host domain fixes #12539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/metadata_writer/src/metadata_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def value_to_mlmd_value(value) -> metadata_store_pb2.Value:

def connect_to_mlmd() -> metadata_store.MetadataStore:
pod_namespace = os.environ.get("POD_NAMESPACE", "kubeflow")
metadata_service_host = "metadata-grpc-service." + pod_namespace + ".svc.cluster.local"
cluster_domain = os.environ.get("CLUSTER_DOMAIN", ".svc.cluster.local")
metadata_service_host = "metadata-grpc-service." + pod_namespace + cluster_domain
metadata_service_port = 8080

mlmd_connection_config = metadata_store_pb2.MetadataStoreClientConfig(
Expand Down