Skip to content

Conversation

@rishabh998186
Copy link

This PR fixes an issue where default pipeline parameters are not shown in the Compare Runs view when a run is created from the UI without changing any parameter values. Previously, parameter values were only propagated when the user interacted with the inputs, so untouched defaults were missing from runtime_config and therefore from Compare Runs.

changes

NewRunParametersV2.tsx


Extend the existing parameter initialization effect to:

1. Build runtimeParametersInRealType from specParameters using convertInput for each parameter type.

2. Call handleParameterChange(runtimeParametersInRealType) once on mount/when spec changes so that:

 * Default parameter values are propagated to the parent (setRuntimeParameters).

 * These defaults are included in runtime_config even if the user does not modify any parameter fields.

3. Preserve the existing validation behavior with setIsValidInput.

NewRunParametersV2.test.tsx

1. Add a test: calls handleParameterChange with default values on mount:

Mount NewRunParametersV2 with a set of parameters of different types: STRING, NUMBER_INTEGER, BOOLEAN, LIST, and STRUCT, each with a defaultValue.

2.Assert that handleParameterChange is:

* Called exactly once.

*Called with the correctly converted runtime values.

3. Assert that these default values are rendered in the UI inputs.

Fixes: #12536

Signed-off-by: rishabh998186 <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @rishabh998186. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rishabh998186 rishabh998186 changed the title [frontend] Fix default parameters not displayed in Compare Runs Fix default parameters not displayed in Compare Runs Dec 9, 2025
@rishabh998186 rishabh998186 changed the title Fix default parameters not displayed in Compare Runs Fix /default parameters not displayed in Compare Runs Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Default parameters not displayed in Compare Runs

1 participant