-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(manifests): Allow same-namespace access to SeaweedFS for standalone deployments #12543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/retest |
.github/resources/manifests/base/allow-same-namespace-networkpolicy.yaml
Show resolved
Hide resolved
df9360b to
4155dc5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@juliusvonkohout can you PTAL on this? |
…ne deployments Signed-off-by: Helber Belmiro <[email protected]>
4155dc5 to
b0ed5b1
Compare
|
Thank you @hbelmiro it looks good and and more robust than before, but may you raise the same PR against kubeflow/manifests to also test the CI/CD there? If it is green and you see a kfp tests, then both are good to merge. |
|
kubeflow/manifests#3306 is merged so and thank you for making it more robust |
|
Just be careful if more than this single port is needed in the future for the same namespace. But that can also be adjusted in the future if needed. |
|
@HumairAK can you please take a final look? |
Description of your changes:
The SeaweedFS NetworkPolicy only allows traffic from namespaces labeled
app.kubernetes.io/part-of: kubeflow-profileor fromistio-system. This blocks the API server (running in thekubeflownamespace) from accessing object storage on clusters with NetworkPolicy enforcement, breaking standalone KFP deployments.Fix: Add an ingress rule allowing same-namespace pod traffic to SeaweedFS on port 8333.
Note: This change aligns with the upstream Kubeflow manifests repository, which deploys a
default-allow-same-namespace.yamlNetworkPolicy for the kubeflow namespace. For standalone KFP, we achieve the same functional result by adding the rule directly to the SeaweedFS policy rather than introducing a separate blanket policy. This keeps the standalone deployment simpler while solving the connectivity issue.Changes
Checklist: