Skip to content

Conversation

@hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Dec 9, 2025

Description of your changes:

The SeaweedFS NetworkPolicy only allows traffic from namespaces labeled app.kubernetes.io/part-of: kubeflow-profile or from istio-system. This blocks the API server (running in the kubeflow namespace) from accessing object storage on clusters with NetworkPolicy enforcement, breaking standalone KFP deployments.

Fix: Add an ingress rule allowing same-namespace pod traffic to SeaweedFS on port 8333.

Note: This change aligns with the upstream Kubeflow manifests repository, which deploys a default-allow-same-namespace.yaml NetworkPolicy for the kubeflow namespace. For standalone KFP, we achieve the same functional result by adding the rule directly to the SeaweedFS policy rather than introducing a separate blanket policy. This keeps the standalone deployment simpler while solving the connectivity issue.

Changes

  • Added same-namespace ingress rule to SeaweedFS NetworkPolicy
  • Fixes standalone deployments by allowing API server and UI to access object storage

Checklist:

@hbelmiro
Copy link
Contributor Author

hbelmiro commented Dec 9, 2025

/retest

@hbelmiro hbelmiro marked this pull request as draft December 10, 2025 17:19
@hbelmiro hbelmiro force-pushed the fix-namespace-manifest branch from df9360b to 4155dc5 Compare December 10, 2025 17:34
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hbelmiro and additionally assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro hbelmiro changed the title fix(manifests): Add kubeflow-profile label to namespace for NetworkPolicy compatibility WIP - fix(manifests): Dec 10, 2025
@hbelmiro hbelmiro marked this pull request as ready for review December 10, 2025 17:47
@hbelmiro
Copy link
Contributor Author

@juliusvonkohout can you PTAL on this?

@hbelmiro hbelmiro force-pushed the fix-namespace-manifest branch from 4155dc5 to b0ed5b1 Compare December 10, 2025 17:51
@hbelmiro hbelmiro changed the title WIP - fix(manifests): fix(manifests): Allow same-namespace access to SeaweedFS for standalone deployments Dec 10, 2025
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Dec 10, 2025

Thank you @hbelmiro it looks good and and more robust than before, but may you raise the same PR against kubeflow/manifests to also test the CI/CD there? If it is green and you see a kfp tests, then both are good to merge.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Dec 11, 2025

kubeflow/manifests#3306 is merged so
/lgtm

and thank you for making it more robust

@juliusvonkohout
Copy link
Member

Just be careful if more than this single port is needed in the future for the same namespace. But that can also be adjusted in the future if needed.

@hbelmiro
Copy link
Contributor Author

@HumairAK can you please take a final look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants