e2e: Capture controller and driver pod logs #2590
Draft
+48
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Adds pod log capturing (spark-operator controller and driver) at the end of e2e tests.
Proposed changes:
AfterEach
blocksChange Category
Rationale
I found this helpful in recent PR work to catch exit logs before the pods go away. Committing it back to see if other folks are interested.
Checklist
Additional Notes
Opening as a draft for feedback. This was useful for me so I'll probably use it again, but I'm happy to close it if the maintainers have another approach for this. I considered installing loki in my kind cluster, for example, but this seemed more straightforward.
I can make documentation updates after discussion with the project team.