Skip to content

Conversation

matschaffer-roblox
Copy link
Contributor

@matschaffer-roblox matschaffer-roblox commented Jul 10, 2025

Purpose of this PR

Adds pod log capturing (spark-operator controller and driver) at the end of e2e tests.

Proposed changes:

  • writePodLogs helper function to write named pod logs
  • writeControllerLogs helper function to write logs from all controller pods
  • add calls to e2e tests are part of AfterEach blocks

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality) (for e2e tests)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

I found this helpful in recent PR work to catch exit logs before the pods go away. Committing it back to see if other folks are interested.

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Opening as a draft for feedback. This was useful for me so I'll probably use it again, but I'm happy to close it if the maintainers have another approach for this. I considered installing loki in my kind cluster, for example, but this seemed more straightforward.

I can make documentation updates after discussion with the project team.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey July 10, 2025 22:23
I found this helpful in recent PR work to catch exit logs before the pods go away. Committing it back to see if other folks are interested.

Signed-off-by: Mat Schaffer <[email protected]>
Signed-off-by: Mat Schaffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant