Extract reusable codes to common utility #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxin Shan <[email protected]>
Move ConvertPodList, ConvertServiceList to common library Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Refactor follow methods to job independent and move to common utils - OnDependentCreateFunc - OnDependentDeleteFunc Signed-off-by: Jiaxin Shan <[email protected]>
|
/cc @kubeflow/wg-training-leads |
Signed-off-by: Jiaxin Shan <[email protected]>
Jeffwan
force-pushed
the
all-in-one-cleanup_new
branch
from
4ff936e to
aff52ba
Compare
gaocegege
approved these changes
Jul 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
added a commit
that referenced
this pull request
Aug 5, 2021
* Remove duplicate FakeWorkQueue Signed-off-by: Jiaxin Shan <[email protected]> * Extract utility to common Move ConvertPodList, ConvertServiceList to common library Signed-off-by: Jiaxin Shan <[email protected]> * Move gang scheduing setting to common Signed-off-by: Jiaxin Shan <[email protected]> * Extract OnDependentCreate/Delete handler to utils Refactor follow methods to job independent and move to common utils - OnDependentCreateFunc - OnDependentDeleteFunc Signed-off-by: Jiaxin Shan <[email protected]> * Refactor SatisfiedExpectations to a common method Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1299 kubeflow/common#138
It resolves "2. Extract common methods to utilities which can be shared by all operators."
In Phase I, we merge apis and controller codes into this repo. However, there're lots of duplication and similar methods. In Phase II, we are try to refactor these similar redeclared codes to make them generally usable. This PR is the first one of Phase II.
convertServiceList,convertPodList,IsGangSchedulerSetto common utils.