Skip to content

feat: configure ACL sampling in install script - #7173

Open
zhangzujian wants to merge 3 commits into
feature/acl-sampling-docsfrom
feature/acl-sampling-install-script
Open

feat: configure ACL sampling in install script#7173
zhangzujian wants to merge 3 commits into
feature/acl-sampling-docsfrom
feature/acl-sampling-install-script

Conversation

@zhangzujian

@zhangzujian zhangzujian commented Aug 7, 2026

Copy link
Copy Markdown
Member

Related to #7146.

Summary

  • expose ACL sampling through the manifest-based dist/images/install.sh path used by Kind and CI jobs
  • keep installer defaults aligned with both Helm charts and keep the feature disabled by default
  • pass controller-side application, collector, set, and probability settings to kube-ovn-controller
  • pass enabled flag, shared set ID, and local psample group ID to every CNI agent
  • document equivalent installer environment variables
  • add a shell regression test for defaults, overrides, and template argument wiring

Stack

  1. feat: add ACL sampling configuration #7149 — configuration
  2. feat: allocate stable ACL sample metadata #7150 — stable metadata allocator
  3. feat: reconcile OVN ACL sampling objects #7148 — OVN sampling object reconciler
  4. feat: attach sampling to NetworkPolicy ACLs #7163 — NetworkPolicy ACL attachment
  5. feat: retry NetworkPolicy ACL sampling independently #7164 — sampling-only retry and enforcement isolation
  6. feat: clean up owned ACL sampling state #7165 — ownership-aware disable and cleanup
  7. feat: report ACL sampling availability #7166 — controller availability metrics
  8. feat: deliver ACL samples locally on nodes #7167 — node-local psample delivery
  9. feat: decode NetworkPolicy ACL samples #7168 — cookie and metadata event decoder
  10. feat: listen for local ACL samples #7169 — Linux psample listener
  11. feat: add ACL sample debug commands #7170 — ACL sample debug commands
  12. feat: configure ACL sampling in v2 chart #7171 — v2 chart configuration
  13. docs: describe NetworkPolicy ACL sampling #7172 — operations and compatibility documentation
  14. feat: configure ACL sampling in install script #7173 — manifest installer configuration
  15. test: add ACL sampling end-to-end coverage #7174 — end-to-end coverage

Merge in listed order. Each PR targets preceding stack branch.

Base: feature/acl-sampling-docs

Validation

  • bash -n dist/images/install.sh dist/images/install-acl-sampling_test.sh
  • bash dist/images/install-acl-sampling_test.sh
  • shellcheck dist/images/install-acl-sampling_test.sh
  • git diff --check

@mergify

mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ The sha of the head commit of this PR conflicts with #7161. Mergify cannot evaluate rules on this PR. Once #7161 is merged or closed, Mergify will resume processing this PR. ⚠️

@zhangzujian
zhangzujian marked this pull request as ready for review August 7, 2026 10:31
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New network feature test automation tests labels Aug 7, 2026
@zhangzujian zhangzujian closed this Aug 7, 2026
@zhangzujian zhangzujian reopened this Aug 7, 2026
@zhangzujian
zhangzujian force-pushed the feature/acl-sampling-install-script branch from d2a3012 to 9637798 Compare August 7, 2026 10:44
@zhangzujian
zhangzujian force-pushed the feature/acl-sampling-install-script branch from 9637798 to 26f4ec4 Compare August 7, 2026 10:53
@coveralls

coveralls commented Aug 7, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 31387141586

Warning

No base build found for commit 2761b07 on feature/acl-sampling-docs.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 32.544%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 65125
Covered Lines: 21194
Line Coverage: 32.54%
Coverage Strength: 0.38 hits per line

💛 - Coveralls

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian
zhangzujian force-pushed the feature/acl-sampling-install-script branch from ee0a5fd to 6634ee9 Compare August 10, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New network feature size:M This PR changes 30-99 lines, ignoring generated files. test automation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants